Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Removed symbols have no remaining references, and both modified dashboards remain valid JSON.
Review effort: Balanced
Findings: None
What changed in this PR
Removes unused OM metrics and their obsolete dashboard references.
Changes:
- Removes unmodified S3, access-check, and trash counters.
- Removes the obsolete S3 bucket panel and updates dashboard text/layout.
| File | Description |
|---|---|
OMMetrics.java |
Removes unused counters and methods. |
Ozone - Overall Metrics.json |
Removes obsolete panel and closes the layout gap. |
Ozone - OM Overview.json |
Removes outdated metric commentary. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
chungen0126
left a comment
chungen0126
left a comment
There was a problem hiding this comment.
Thanks @chihsuan for working on this.
| @@ -1331,16 +1263,6 @@ public long getNumGetServiceListFails() { | |||
| return numGetServiceListFails.value(); | |||
There was a problem hiding this comment.
Seems like this can be removed as well?
There was a problem hiding this comment.
Seems like this can be removed as well?
There was a problem hiding this comment.
I originally left it for HDDS-16719, but agree it's unused. Removed in 4b20d31.
| @@ -146,7 +143,6 @@ public class OMMetrics implements OmMetadataReaderMetrics { | |||
| private @Metric MutableCounterLong numKeyCommitFails; | |||
| private @Metric MutableCounterLong numBlockAllocationFails; | |||
| private @Metric MutableCounterLong numGetServiceListFails; | |||
There was a problem hiding this comment.
Maybe we could remove it as well.
# Conflicts: # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java
What changes were proposed?
Removes 12 OMMetrics counters that are never updated: S3 bucket metrics, volume check access metrics, and unused trash metrics. Also removes their Grafana dashboard references.
These metrics will no longer be exported through
/promor JMX. Custom dashboards and alerts referencing them will need updating.This cleanup is separate from #11410, as requested in its review.
JIRA
https://issues.apache.org/jira/browse/HDDS-16726
How was this patch tested?
CI: https://github.com/chihsuan/ozone/actions/runs/37472390734
Generated-by: Claude Code (Claude Opus 5.5)